feat(Kubernetes Client): integrate dotnet kubernetes client into KubeOps #507
+1,208
−787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Big "Thank you" to @Silvenga for the initial work on this. This closes #435. This fixes #434. BREAKING CHANGE: This moves to System.Text.Json from Newtonsoft.Json to adhere to the changes in Kubernetes Client upstream. Existing projects must migrate from using `JsonPropertyAttributes` to `JsonPropertyNameAttributes`. The YAML serializer is also shared with `kubernetes-client` and is no longer overridable via injection. `Microsoft.Rest.HttpOperationException` no longer exists, any place this is used must move to `k8s.Autorest.HttpOperationException`. Signed-off-by: Christoph Bühler <christoph@smartive.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big "Thank you" to @Silvenga for the initial work on this.
This closes #435.
This fixes #434.
BREAKING CHANGE: This moves to System.Text.Json from Newtonsoft.Json to adhere to the changes in Kubernetes Client upstream. Existing projects must migrate from using
JsonPropertyAttributestoJsonPropertyNameAttributes.The YAML serializer is also shared with
kubernetes-clientand is no longer overridable via injection.Microsoft.Rest.HttpOperationExceptionno longer exists, any place this is used must move tok8s.Autorest.HttpOperationException.