Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate.proto is still in proto2, which is not supported by codegen of Ruby #259

Closed
gongcon opened this issue Aug 7, 2019 · 4 comments
Closed
Labels
Question Question about the library Stale Activity has stalled on this issue/pull-request

Comments

@gongcon
Copy link

gongcon commented Aug 7, 2019

Protobuf is not going to add support of proto2 in Ruby, see here. The fundamental validate.proto in still in v2. We are not able to generate Ruby code because of that. The goal we are trying achieve is to stream access log to Logslash, which is written in Ruby.

Found another request here: #113. Is there any plan to implement that?

@rmichela
Copy link
Contributor

rmichela commented Aug 8, 2019

Based on @rodaine's comments in the linked issue, switching from proto2 to proto3 for validate.proto would be both a breaking change for PGV, and not particularly useful towards fixing your issue with the Ruby generator.

validate.proto imports and heavily depends on descriptor.proto, which is itself proto2. Migrating validate.proto to proto3 would not fix your problem. It would only push your problem around.

@rmichela rmichela added the Question Question about the library label Aug 8, 2019
@gongcon
Copy link
Author

gongcon commented Aug 8, 2019

I think the outgoing data should not have the dependencies back on the configurations. It will resolve my problem if it can be a standalone proto file without such kind of dependencies.

@rmichela
Copy link
Contributor

rmichela commented Aug 9, 2019

Due to the nature of protobuf extensions, validate.proto and descriptor.proto are inseparable. https://github.com/envoyproxy/protoc-gen-validate/blob/master/validate/validate.proto#L12-L30

@stale
Copy link

stale bot commented Sep 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Activity has stalled on this issue/pull-request label Sep 8, 2019
@stale stale bot closed this as completed Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question Question about the library Stale Activity has stalled on this issue/pull-request
Projects
None yet
Development

No branches or pull requests

2 participants