{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":523767396,"defaultBranch":"main","name":"protocompile","ownerLogin":"bufbuild","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-08-11T15:06:04.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/54191850?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717107942.0","currentOid":""},"activityList":{"items":[{"before":"e01bb2d3b5ff7079ed3b66822d9c3886ed8f623e","after":"f8a8f6772c150bd2199d882a8cd8599b87f477b6","ref":"refs/heads/jh/wellknownimports","pushedAt":"2024-05-30T22:26:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"add wellknownimports package, for providing actual source code","shortMessageHtmlLink":"add wellknownimports package, for providing actual source code"}},{"before":"f4bf5a3687ba2f8f731580d2c97bdec464f38264","after":null,"ref":"refs/heads/jh/feature-support-in-enum-vals","pushedAt":"2024-05-30T22:25:42.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"}},{"before":"85801e40daf19567e438fec40d290dcb8840ca3a","after":"4190af10a5e22d8764ccca70ad62d23f56b978c2","ref":"refs/heads/main","pushedAt":"2024-05-30T22:25:41.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"Add final checks that were added to protoc between v27.0-rc3 and final v27.0 (#309)\n\nThis change mirrors two of the changes in the final v27.0 of protoc\r\nthat were not previously implemented in this compiler:\r\n\r\n1. A new `feature_support` field on `EnumValueOptions` to allow defining\r\nthe lifetime of a feature value. This is similar to the field of the\r\nsame name and type on `FieldOptions`, but it controls the actual enum\r\nvalues and in which editions they are valid.\r\n2. A new check that a feature is not used from the same file in which\r\nit's defined.\r\n\r\nThis change updates this repo to use the latest (final) v27.0 release and\r\nalso updates the protobuf-go dependency to include the v27.0 version\r\nof the `descriptorpb` package.","shortMessageHtmlLink":"Add final checks that were added to protoc between v27.0-rc3 and fina…"}},{"before":"55af3d5a5ef71928ee5f18f6c37ef0d552d457a5","after":"e01bb2d3b5ff7079ed3b66822d9c3886ed8f623e","ref":"refs/heads/jh/wellknownimports","pushedAt":"2024-05-30T13:18:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"add wellknownimports package, for providing actual source code","shortMessageHtmlLink":"add wellknownimports package, for providing actual source code"}},{"before":"3d2f168244a9c34ccff607e5f99fdeb583df8358","after":"55af3d5a5ef71928ee5f18f6c37ef0d552d457a5","ref":"refs/heads/jh/wellknownimports","pushedAt":"2024-05-30T03:25:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"add wellknownimports package, for providing actual source code","shortMessageHtmlLink":"add wellknownimports package, for providing actual source code"}},{"before":null,"after":"3d2f168244a9c34ccff607e5f99fdeb583df8358","ref":"refs/heads/jh/wellknownimports","pushedAt":"2024-05-30T03:17:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"add wellknownimports package, for providing actual source code","shortMessageHtmlLink":"add wellknownimports package, for providing actual source code"}},{"before":null,"after":"f4bf5a3687ba2f8f731580d2c97bdec464f38264","ref":"refs/heads/jh/feature-support-in-enum-vals","pushedAt":"2024-05-30T02:00:35.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"a feature cannot be used in the same file in which it's defined (new validation added in protoc v27.0)","shortMessageHtmlLink":"a feature cannot be used in the same file in which it's defined (new …"}},{"before":"9cf5161b7caa4a52b4525735f487ec4ec1df09b4","after":null,"ref":"refs/heads/dependabot/go_modules/internal/tools/github.com/bufbuild/buf-1.32.0","pushedAt":"2024-05-27T20:34:11.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":null,"after":"09f1d42c4b57f5fcb308755054549b5baa137855","ref":"refs/heads/dependabot/go_modules/internal/tools/github.com/bufbuild/buf-1.32.1","pushedAt":"2024-05-27T20:34:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump github.com/bufbuild/buf from 1.31.0 to 1.32.1 in /internal/tools\n\nBumps [github.com/bufbuild/buf](https://github.com/bufbuild/buf) from 1.31.0 to 1.32.1.\n- [Release notes](https://github.com/bufbuild/buf/releases)\n- [Changelog](https://github.com/bufbuild/buf/blob/main/CHANGELOG.md)\n- [Commits](https://github.com/bufbuild/buf/compare/v1.31.0...v1.32.1)\n\n---\nupdated-dependencies:\n- dependency-name: github.com/bufbuild/buf\n  dependency-type: direct:production\n  update-type: version-update:semver-minor\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump github.com/bufbuild/buf from 1.31.0 to 1.32.1 in /internal/tools"}},{"before":"01bcced5bae2896468ca0a07514db77ed2402317","after":null,"ref":"refs/heads/jh/more-thorough-resolve-custom","pushedAt":"2024-05-22T13:09:31.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"}},{"before":"752249dfc37f06340a14eee3fc14684d3f94ddb6","after":"85801e40daf19567e438fec40d290dcb8840ca3a","ref":"refs/heads/main","pushedAt":"2024-05-22T13:09:30.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"Add more thorough checks for when to adapt a value when resolving custom feature (#306)\n\nPreviously, the protoutil.ResolveCustomFeature code was unable to\r\nreliably handle the following case:\r\n1. The descriptor includes dynamic extensions for all custom options and\r\ncustom features.\r\n2. The user supplies a _generated_ extension type, to query for the\r\ncustom feature.\r\n\r\nThe code here _ostensibly_ handles this. But the cases where it decides\r\nit needs to adapt the value (by marshalling and then unmarshalling into\r\ndifferent type) isn't quite thorough enough. The issue is when the\r\ncustom feature is a _message_. In that case, it works fine to query for\r\nthe extension itself. But if we then need to extract a field from the\r\nmessage, the field descriptor is likely referring to a generated message\r\ntype, whose descriptor is an instance in `protoregistry.GlobalTypes`.\r\nBut the value is likely to be a dynamic message, whose descriptor may\r\nhave been constructed dynamically (such as being parsed from source). In\r\nthat case, the `protoreflect` stuff will happily panic when it sees the\r\nmismatch 😱.\r\n\r\nThis commit fixes this issue so that custom feature values can be\r\nsuccessfully queried under these conditions, without panic.","shortMessageHtmlLink":"Add more thorough checks for when to adapt a value when resolving cus…"}},{"before":"2a47c77d8cc56436dcf9bc597f092d4f84df0b61","after":"01bcced5bae2896468ca0a07514db77ed2402317","ref":"refs/heads/jh/more-thorough-resolve-custom","pushedAt":"2024-05-22T13:03:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"minor cleanup in test since file value is always false","shortMessageHtmlLink":"minor cleanup in test since file value is always false"}},{"before":null,"after":"9cf5161b7caa4a52b4525735f487ec4ec1df09b4","ref":"refs/heads/dependabot/go_modules/internal/tools/github.com/bufbuild/buf-1.32.0","pushedAt":"2024-05-20T20:39:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"---\nupdated-dependencies:\n- dependency-name: github.com/bufbuild/buf\n  dependency-type: direct:production\n  update-type: version-update:semver-minor\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"---"}},{"before":"45da2c066a7fc301328c95565b4c37c2620272a5","after":"2a47c77d8cc56436dcf9bc597f092d4f84df0b61","ref":"refs/heads/jh/more-thorough-resolve-custom","pushedAt":"2024-05-20T17:29:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"make linter happy","shortMessageHtmlLink":"make linter happy"}},{"before":"27e5e21d3950395a700d369952d317be85b69a62","after":"45da2c066a7fc301328c95565b4c37c2620272a5","ref":"refs/heads/jh/more-thorough-resolve-custom","pushedAt":"2024-05-20T17:02:46.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"fix logic bugs in previous commit","shortMessageHtmlLink":"fix logic bugs in previous commit"}},{"before":null,"after":"27e5e21d3950395a700d369952d317be85b69a62","ref":"refs/heads/jh/more-thorough-resolve-custom","pushedAt":"2024-05-10T20:18:42.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"more thorough checks to see if we need to adapt (marshal+unmarshal) value to right descriptor","shortMessageHtmlLink":"more thorough checks to see if we need to adapt (marshal+unmarshal) v…"}},{"before":"a4a8b9557f82affbf6a1447db91c3c5d418a9dc7","after":null,"ref":"refs/heads/jh/oops-fix-typo-in-editions","pushedAt":"2024-05-10T20:18:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"}},{"before":"217975435957fc6eeb71fcda08db6bb4b9839a50","after":"752249dfc37f06340a14eee3fc14684d3f94ddb6","ref":"refs/heads/main","pushedAt":"2024-05-10T20:18:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"Fix a typo in code that adapts/re-parses features to match a descriptor (#305)","shortMessageHtmlLink":"Fix a typo in code that adapts/re-parses features to match a descript…"}},{"before":"56bd682dc0a35f36f2a4960758b1fbd9d0e1b406","after":"a4a8b9557f82affbf6a1447db91c3c5d418a9dc7","ref":"refs/heads/jh/oops-fix-typo-in-editions","pushedAt":"2024-05-10T19:22:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"add test case that repros issue","shortMessageHtmlLink":"add test case that repros issue"}},{"before":null,"after":"56bd682dc0a35f36f2a4960758b1fbd9d0e1b406","ref":"refs/heads/jh/oops-fix-typo-in-editions","pushedAt":"2024-05-10T16:40:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"ugh, typo","shortMessageHtmlLink":"ugh, typo"}},{"before":"70860afff45d3b4224cfeb579a318f5d541ab04d","after":null,"ref":"refs/heads/jh/add-edition-declarations-test","pushedAt":"2024-05-10T14:07:54.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"}},{"before":"54ef548a6198ab73e6fdc9b9f4a9eb1ccee71d50","after":"217975435957fc6eeb71fcda08db6bb4b9839a50","ref":"refs/heads/main","pushedAt":"2024-05-10T14:07:53.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"Add another test case for extension declarations (#304)\n\nThis makes sure that declarations are enforced, even when no\r\ndeclarations are present, as long as `verification` is explicitly set to\r\n`DECLARATION`.","shortMessageHtmlLink":"Add another test case for extension declarations (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2289712467\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bufbuild/protocompile/issues/304\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bufbuild/protocompile/pull/304/hovercard\" href=\"https://github.com/bufbuild/protocompile/pull/304\">#304</a>)"}},{"before":null,"after":"70860afff45d3b4224cfeb579a318f5d541ab04d","ref":"refs/heads/jh/add-edition-declarations-test","pushedAt":"2024-05-10T12:52:21.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"test case with verification set but no declarations to make sure they are enforced","shortMessageHtmlLink":"test case with verification set but no declarations to make sure they…"}},{"before":"0dcf9c7107df6aa18a609c79feb57ec61071a280","after":null,"ref":"refs/heads/jh/editions-ga","pushedAt":"2024-05-09T18:59:28.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"}},{"before":"6e58a0c124ca0327e119151cb77de9382157cc7e","after":"54ef548a6198ab73e6fdc9b9f4a9eb1ccee71d50","ref":"refs/heads/main","pushedAt":"2024-05-09T18:59:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"Last change for Editions: enforce feature lifetimes, and make it available to users (#301)\n\nThis updates to protobuf-go v1.34.1, which provides the latest\r\n`descriptor.proto` updates in its `descriptorpb` package. With that, we\r\nare able to implement the final change before allowing end-users to use\r\nprotocompile with editions: enforcing feature lifetimes.\r\n\r\nSo this PR implements that last change and also makes Editions\r\ngenerally available: it's no longer disabled-by-default, requiring\r\nopt-in via \"testing\" method.\r\n\r\nThe last change is a check to verify that a feature isn't being used outside\r\nits expected lifetime. This PR also adds an exported helper to the root\r\nprotocompile package: IsEditionSupported. This advertises to consumers\r\nof the package which editions it can compile.","shortMessageHtmlLink":"Last change for Editions: enforce feature lifetimes, and make it avai…"}},{"before":"adc3bfffcffe80cd66d76d013e119d99c1255547","after":"0dcf9c7107df6aa18a609c79feb57ec61071a280","ref":"refs/heads/jh/editions-ga","pushedAt":"2024-05-09T18:52:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"model supported editions as a range instead of (possibly non-contiguous) set","shortMessageHtmlLink":"model supported editions as a range instead of (possibly non-contiguo…"}},{"before":"035b905e88327061cbb100a0b7b5dd8bc71f029b","after":"adc3bfffcffe80cd66d76d013e119d99c1255547","ref":"refs/heads/jh/editions-ga","pushedAt":"2024-05-09T18:40:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"simplify boolean arithmatic\n\nCo-authored-by: Edward McFarlane <3036610+emcfarlane@users.noreply.github.com>","shortMessageHtmlLink":"simplify boolean arithmatic"}},{"before":"8de2e39002704ee6d0127de2e29f36bc4a18e5df","after":"035b905e88327061cbb100a0b7b5dd8bc71f029b","ref":"refs/heads/jh/editions-ga","pushedAt":"2024-05-09T18:40:27.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"jhump","name":"Joshua Humphries","path":"/jhump","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2035234?s=80&v=4"},"commit":{"message":"Merge branch 'main' into jh/editions-ga","shortMessageHtmlLink":"Merge branch 'main' into jh/editions-ga"}},{"before":"c636e33d771a154967b362809a10fb1ab04830fd","after":null,"ref":"refs/heads/dependabot/go_modules/internal/benchmarks/google.golang.org/protobuf-1.34.1","pushedAt":"2024-05-09T18:37:59.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":"d76081a21efa6fce8948a4bcea66976a9310fc0a","after":null,"ref":"refs/heads/dependabot/go_modules/google.golang.org/protobuf-1.34.1","pushedAt":"2024-05-09T18:37:41.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWHkTXwA","startCursor":null,"endCursor":null}},"title":"Activity · bufbuild/protocompile"}