Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTK file chooser looks very bad #91

Closed
2 tasks done
anuejn opened this issue Oct 13, 2021 · 4 comments · Fixed by #93
Closed
2 tasks done

GTK file chooser looks very bad #91

anuejn opened this issue Oct 13, 2021 · 4 comments · Fixed by #93

Comments

@anuejn
Copy link
Member

anuejn commented Oct 13, 2021 •
edited

  • It is not correctly attached to the audapolis window
  • it has gtk-cancel and gtk-save as literal strings in the gui
@anuejn
Copy link
Member Author

anuejn commented Oct 14, 2021

ok appearently the second issue is (electron/electron#30247)

@anuejn
Copy link
Member Author

anuejn commented Oct 14, 2021

booth seem to be fixed by downgrading to electron 13.x

@anuejn
Copy link
Member Author

anuejn commented Oct 14, 2021

(maybe electron/electron#31152 is related)

anuejn added a commit that referenced this issue Oct 14, 2021
@anuejn
🐛 Fix ugly gtk filechooser
f2e8e30 
this is mostly done by downgrading to elcectron 13.x :(. Fixes #91.
@anuejn anuejn mentioned this issue Oct 14, 2021
Merged
pajowu pushed a commit that referenced this issue Oct 15, 2021
@anuejn @pajowu
🐛 Fix ugly gtk filechooser
a26c041 
this is mostly done by downgrading to elcectron 13.x :(. Fixes #91.
pajowu pushed a commit that referenced this issue Oct 15, 2021
@anuejn @pajowu
🐛 Fix ugly gtk filechooser
03e03b0 
this is mostly done by downgrading to elcectron 13.x :(. Fixes #91.
@anuejn
Copy link
Member Author

anuejn commented Dec 12, 2021

probably electron/electron#19159 is also related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Fix ugly gtk filechooser bugbakery/audapolis
1 participant
@anuejn