-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unreadable test result #6453
Comments
Hi, do you have a link to this invocation on our cloud instance that you could share (or DM me in our Slack channel) if you're using hosted BuildBuddy? Or if not, do you mind downloading the test.xml file from that page and attaching it here? This test page is showing the results of the test.xml file so having that file would let us understand this issue a little better. |
Sure, here it is: test.xml.zip |
@bduffany is given test.xml helpful? Maybe, something else needed? |
@evis it seems like the error was printed as is from your
Is this what you are expecting from your test? |
The problematic part from the snippet that Son showed is this part:
note that the message is quite verbose and contains entities like I don't have a ton of experience with these XML files and hoping other folks can chime in if they have more experience with this, but from reading the XML schema documentation here I think that in normal usage, the Which bazel test rules are you using? is it just |
Given @evis profile, I think it's from rules_scala with https://github.com/bazelbuild/rules_scala/blob/e2fe29c3b51647ecd07a562917c2c09fb48f9c0a/scala/support/JUnitXmlReporter.scala#L412-L437 |
A quick fix that I could think of is to patch rules_scala so that the @evis could you please open an issue on rules_scala to report this? I think rules_scala maintainers would have more context on how |
Since this is XML, shouldn't the entities be translated correctly when displayed? So |
Yeah, I think it's encoded twice. Once in rules_scala for We could reverse these operations on our end. However, it does not change the fact that rules_scala is being silly, fitting a huge stack trace into the I think the correct fix here is to ensure that Ima close this as not planned. We could reopen the issue if there is a valid use case for new line characters inside these XML attributes. |
Test result is quite unreadable sometimes.
Screenshots
Test log: build_logs.txt
The text was updated successfully, but these errors were encountered: