Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow multiple cache images for one service #171

Merged
merged 1 commit into from Dec 10, 2018
Merged

allow multiple cache images for one service #171

merged 1 commit into from Dec 10, 2018

Conversation

dreyks
Copy link
Contributor

@dreyks dreyks commented Sep 16, 2018

First image that gets successfully pulled stops the chain for this service. The idea is to have

cache-from:
  - app:myrepo/myapp:${BUILDKITE_BRANCH}
  - app:myrepo/myapp:latest

so that subsequent builds for a branch will use the cache for this specific branch

@dreyks
Copy link
Contributor Author

dreyks commented Oct 3, 2018

@lox any thoughts?

@keithpitt
Copy link

This change looks good to me! I'll poke @lox about it today and try it get it merged.

@lox
Copy link
Contributor

lox commented Dec 10, 2018

I was hesitant to merge because I've made some pretty major changes to the cache-from mechanism in several if my WIP PR's, but I reckon the utility of the change outweighs those concerns. Sorry for the delay @dreyks!

@lox lox merged commit d512bd3 into buildkite-plugins:master Dec 10, 2018
@lox
Copy link
Contributor

lox commented Dec 10, 2018

I'll follow up with some docs changes to reflect.

toolmantim added a commit that referenced this pull request Dec 22, 2018
@toolmantim
Copy link
Contributor

This was released in v2.6.0 (🎄 Holiday Cheer) 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants