Move cleanup to a pre-exit hook to handle cancel #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be great to get this merged, it's causing build failures when the networks pile up. |
|
Sorry for the delay @robholland, was doing some thinking about whether there was anything else this could break, but let's just merge it and see! |
lox
force-pushed
the
cleanup-in-pre-exit
branch
from
564fcac
to
dee2d9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a job is cancelled, it will kill the command hook and often docker-compose won't have time to cleanup. This moves the cancellation to a
pre-exithook to give it more time to run.Closes #169.