Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support use aliases so network aliases can be used with the plugin #182

Merged
merged 1 commit into from Dec 14, 2018
Merged

Support use aliases so network aliases can be used with the plugin #182

merged 1 commit into from Dec 14, 2018

Conversation

snmaynard
Copy link
Contributor

I use network aliases during some of our pipelines and so the docker-compose run command needs to have the --use-aliases option so that they actually take effect.

toolmantim
toolmantim reviewed Dec 13, 2018
View reviewed changes
Copy link
Contributor

@toolmantim toolmantim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Simon! Any chance you could add it the readme’s list of configuration options too?

@snmaynard
Copy link
Contributor Author

Apologies - done! I just lifted the explanation from the help output from docker-compose run --help but can adjust if you feel its cryptic in that context.

@lox
Copy link
Contributor

lox commented Dec 14, 2018

Looks good, thanks @snmaynard!

@lox lox merged commit 51cc6ca into buildkite-plugins:master Dec 14, 2018
@toolmantim
Copy link
Contributor

This was released in v2.6.0 (🎄 Holiday Cheer) 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toolmantim toolmantim toolmantim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snmaynard @lox @toolmantim