Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user flag to plugin + cleanup scripts #183

Merged
merged 2 commits into from Dec 22, 2018

Conversation

TheDen
Copy link
Contributor

@TheDen TheDen commented Dec 21, 2018

Adds the docker-compose run --user option for run

README.md Outdated
@@ -338,6 +338,10 @@ A list of either KEY or KEY=VALUE that are passed through as environment variabl

Specify the container working directory via `docker-compose run --workdir`.

### `workdir` (optional, run only)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### `workdir` (optional, run only)
### `user` (optional, run only)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that @toolmantim 👍

Copy link
Contributor

@toolmantim toolmantim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This PR looks good. There’s just one small change tho, which I’ve suggested above.

@toolmantim toolmantim merged commit fda1bf4 into buildkite-plugins:master Dec 22, 2018
@toolmantim
Copy link
Contributor

This was released in v2.6.0 (🎄 Holiday Cheer) 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants