Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: buildkite-plugins/test-collector-buildkite-plugin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.6.0
Choose a base ref
...
head repository: buildkite-plugins/test-collector-buildkite-plugin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.6.1
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Mar 19, 2023

  1. Corrected follow-symlink variable option

    @toote
    toote committed Mar 19, 2023
    Copy the full SHA
    8c2b6f1 View commit details

  2. Correct tests to use the correct environment variable

    @toote
    toote committed Mar 19, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    ab4a375 View commit details

Commits on Mar 21, 2023

  1. Merge pull request #45 from buildkite-plugins/toote_symlink_fix 

    Follow symlink feature fix
    @pzeballos
    pzeballos authored Mar 21, 2023
    Copy the full SHA
    6581c4e View commit details
Showing with 3 additions and 3 deletions.
  1. +1 −1 hooks/pre-exit
  2. +2 −2 tests/pre-exit-success.bats
2 changes: 1 addition & 1 deletion hooks/pre-exit
View file
Original file line number Diff line number Diff line change
@@ -95,7 +95,7 @@ fi

FIND_CMD=(find)

if [[ "${BUILDKITE_PLUGIN_TEST_COLLECTOR_FOLLOW_LINKS:-}" =~ ^(true|on|1|always)$ ]]; then
if [[ "${BUILDKITE_PLUGIN_TEST_COLLECTOR_FOLLOW_SYMLINKS:-}" =~ ^(true|on|1|always)$ ]]; then
FIND_CMD+=('-L')
fi

4 changes: 2 additions & 2 deletions tests/pre-exit-success.bats
View file
Original file line number Diff line number Diff line change
@@ -124,7 +124,7 @@ COMMON_CURL_OPTIONS='--form \* --form \* --form \* --form \* --form \* --form \*
}

@test "Follow links option enabled adds find option" {
export BUILDKITE_PLUGIN_TEST_COLLECTOR_FOLLOW_LINKS='true'
export BUILDKITE_PLUGIN_TEST_COLLECTOR_FOLLOW_SYMLINKS='true'

stub find "-L . -path \* : echo './tests/fixtures/junit-1.xml'"
stub curl "-X POST --silent --show-error --max-time 30 --form format=junit ${COMMON_CURL_OPTIONS} \* -H \* : echo 'curl success'"
@@ -139,7 +139,7 @@ COMMON_CURL_OPTIONS='--form \* --form \* --form \* --form \* --form \* --form \*
}

@test "Follow links option disabled does not add find option" {
export BUILDKITE_PLUGIN_TEST_COLLECTOR_FOLLOW_LINKS='false'
export BUILDKITE_PLUGIN_TEST_COLLECTOR_FOLLOW_SYMLINKS='false'

stub find ". -path \* : echo './tests/fixtures/junit-1.xml'"
stub curl "-X POST --silent --show-error --max-time 30 --form format=junit ${COMMON_CURL_OPTIONS} \* -H \* : echo 'curl success'"