Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation does not work for github merge queue #2588

Open
prestonvanloon opened this issue Dec 8, 2023 · 0 comments
Open

Documentation does not work for github merge queue #2588

prestonvanloon opened this issue Dec 8, 2023 · 0 comments

Comments

@prestonvanloon
Copy link

This tutorial leaves out an important step that the enables "merge_group" webhook events.

https://buildkite.com/docs/tutorials/github-merge-queue

See github's documentation that says your CI needs to have merge_group with the type checks_requested.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#merge_group

Additionally, enabling Skip builds with existing commits is a bad suggestion for pipelines that run certain jobs only on the main branch. I.e. anything that is triggered after the PR submits won't trigger with this setting on and using merge queue.

Lastly, buildkite's internal documentation for setting up github integrations tells the user to set up the webhook without "merge_group".

Screenshot_2023-12-08_09-37-08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant