Skip to content

Commit 42d3f07

Browse files
sjuddglide-copybara-robot
authored andcommittedOct 23, 2019
Avoid ArrayList#addAll when setting bucket priorities.
Fixes #3296 PiperOrigin-RevId: 276299510
1 parent c643255 commit 42d3f07

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed
 

‎library/src/main/java/com/bumptech/glide/provider/ResourceDecoderRegistry.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,11 @@ public class ResourceDecoderRegistry {
2020
public synchronized void setBucketPriorityList(@NonNull List<String> buckets) {
2121
List<String> previousBuckets = new ArrayList<>(bucketPriorityList);
2222
bucketPriorityList.clear();
23-
bucketPriorityList.addAll(buckets);
23+
// new ArrayList(List) and ArrayList#addAll(List) are both broken on some verisons of Android,
24+
// see #3296
25+
for (String bucket : buckets) {
26+
bucketPriorityList.add(bucket);
27+
}
2428
for (String previousBucket : previousBuckets) {
2529
if (!buckets.contains(previousBucket)) {
2630
// Keep any buckets from the previous list that aren't included here, but but them at the

0 commit comments

Comments
 (0)
Please sign in to comment.