Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger/DOC doesn't fit to API #203

Open
ternes3 opened this issue Feb 10, 2023 · 2 comments
Open

Swagger/DOC doesn't fit to API #203

ternes3 opened this issue Feb 10, 2023 · 2 comments

Comments

@ternes3
Copy link

ternes3 commented Feb 10, 2023

I am currently working on an application that will make some of my work with bunq easier. For this, I have generated a client from the Swagger file in the master via the OpenAPI generator.

I have now noticed some differences in the documentation and the use of the API during programming.

For example, GET /v1/user/$userId/monetary-account/ returns a MonetaryAccountListing, whereas the attributes monetaryAccountBank and monetaryAccountJoint are supposed to be a MonetaryAccount[Bank|Joint] object. I have switched to using a MonetaryAccount[Bank|Joint] listing. The current MonetaryAccount[Bank|Joint] object does not even contain a BunqId. That doesn't fit somehow.

Another example is a POST to "/v1/user/$userId/monetary-account/$monetaryAccountId/request-inquiry.

According to the documentation, a RequestInguiry expects a LabelMonetaryAccount as "counterparty_alias". However, it should be a Pointer Object, so that it will work against the API.

Since doc.bunq.com is also generated from the Swagger file, the description there is also wrong / not applicable.

@ternes3
Copy link
Author

ternes3 commented Feb 10, 2023

Additional example for GET /v1/user/$userId/monetary-account/$monateryId/schedule-payment
Bildschirm­foto 2023-02-10 um 19 04 27

@agonbina
Copy link

agonbina commented Nov 5, 2023

The definitions being wrong defeats the purpose of even providing a Swagger file in the first place. I thought the Bunq apps are built on top of the public APIs which can be used by developers too? Do you have an internal definition of the API which is correct?

Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants