Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve visibility of overlapping annotations #279

Open
4 of 7 tasks
bwl21 opened this issue Aug 10, 2019 · 0 comments
Open
4 of 7 tasks

improve visibility of overlapping annotations #279

bwl21 opened this issue Aug 10, 2019 · 0 comments

Comments

@bwl21
Copy link
Owner

bwl21 commented Aug 10, 2019

problem

when annotations are overlapping (e.g. barnumbers, countnotes) none of the two are readible.

solution approach 1

  • improve accuracy of size of annotations
  • draw a white background
    • implement a function to create a white rectangle from Annotation
    • compute backgrounds at the end of layout_voice

solution approach 2

  • improve accuracy of size of annotations
    • handle multilines
    • use character widths instead of a heuristic factor
bwl21 pushed a commit that referenced this issue Aug 16, 2019
* [ ] improve accuracy of size of annotations
* [ ] draw a white background
     * [ ] implement a function to create a white rectangle from Annotation
     * [ ] compute backgrounds at the end of layout_voice
bwl21 pushed a commit that referenced this issue Aug 16, 2019
I still did not manage to include jspdf to the worker, so I remain on counting characters for now
bwl21 pushed a commit that referenced this issue Aug 16, 2019
bwl21 pushed a commit that referenced this issue Aug 16, 2019
fixed position of "u" as countnote
finetuned size of background such that it does not cover synchlines
fixed position of countnotes in bottomup
bwl21 pushed a commit that referenced this issue Aug 16, 2019
bwl21 pushed a commit that referenced this issue Aug 16, 2019
bwl21 pushed a commit that referenced this issue Aug 16, 2019
bwl21 pushed a commit that referenced this issue Aug 16, 2019
bwl21 pushed a commit that referenced this issue Aug 16, 2019
bwl21 pushed a commit that referenced this issue Sep 5, 2019
We update the pdf preview on every render, even if it is not selected.
bwl21 pushed a commit that referenced this issue Oct 16, 2019
bwl21 pushed a commit that referenced this issue Oct 16, 2019
…or parts ...

consider "Überlänge" and "unterlänge"

to amend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant