Add size parameters to IconURL and BannerURL #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds guild icon size parameter, guild banner size parameter, missing ClientStatus struct
FedorLap2006
requested changes
Dec 22, 2022
There was a problem hiding this comment.
In terms of ClientStatus, we'll probably favor #1303, since it also updates the State.
P.S. And it not having the comment is the reason why our linter is angry 😄
Revert addition of ClientStatus since another PR was already merged with it.
Move logic for icon URLs in various functions into a single iconURL function. Similar to banner and avatar functions.
FedorLap2006
approved these changes
Jan 17, 2023
FedorLap2006
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds guild icon size parameter, guild banner size parameter, missing ClientStatus struct