Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should rm be applied to the output got too? #85

Open
eldipa opened this issue Mar 23, 2019 · 0 comments
Open

Should rm be applied to the output got too? #85

eldipa opened this issue Mar 23, 2019 · 0 comments
Labels
enhancement something nice to have but it is not neither critical nor urgent help wanted request for comments a draft idea that needs more brainstorming, comments are welcome!

Comments

@eldipa
Copy link
Collaborator

eldipa commented Mar 23, 2019

Describe the feature you'd like
The rm feature removes a string from the expected output before this is turned into a regex. Should be applied to the output got too?

If an example prints a weird symbol we can remove it. However, if it prints bytes that are invalid in the given encoding, the rm would be too late and this is one of the principal reasons to do this feature.

This should be a backward-compatible change.

Describe alternatives you've considered (optional)
May be we need another option like sanitation to fix any encoding problem?

Additional context (optional)
We need more brainstorming here.

@eldipa eldipa added enhancement something nice to have but it is not neither critical nor urgent help wanted request for comments a draft idea that needs more brainstorming, comments are welcome! labels Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement something nice to have but it is not neither critical nor urgent help wanted request for comments a draft idea that needs more brainstorming, comments are welcome!
Projects
None yet
Development

No branches or pull requests

1 participant