Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enquiry about RePush of Issue & Disable Sql Advise during Git Review #10455

Closed
manideep-qlub opened this issue Jan 22, 2024 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@manideep-qlub
Copy link

Provide the Bytebase version you are using

v2.12.0

Describe the bug

a.) I want to know if its feasible that Bytebase updates the same existing issue if same file is updated in GIT with correct content. Right now if an issue has been created from existing file & if you try to same that sql with correct content & it fails to reflect in same issue & discards it silently.

b.) Second thing I want to know is if it is possible to disable certain SQL Advise during sql review when PR is going to merge. As an example what if we have to disable advisory - https://www.bytebase.com/docs/reference/error-code/advisor#104 to warning may be & not error the Github workflow instead ?

Steps to reproduce

General Questions

Expected behavior

General Questions

Provide the database you are using

Postgres

Provide the version control system you are using

Github

Additional context

No response

@manideep-qlub manideep-qlub added the bug Something isn't working label Jan 22, 2024
@h3n4l h3n4l self-assigned this Jan 22, 2024
@h3n4l
Copy link
Member

h3n4l commented Jan 23, 2024

Hi @manideep-qlub, thanks for your feedback.

I want to know if its feasible that Bytebase updates the same existing issue if same file is updated in GIT with correct content.

This is the expected behavior for the Bytebase GitOps Workflow, as you may encounter certain cases. Could you please share with us the VCS Provider Type (GitHub, GitLab, Azure DevOps, etc) and version? Additionally, are there any differences between your steps and the following steps:

  1. Create a file in VCS and Bytebase will create the corresponding issue.
  2. Modify the content of the file created in step 1, but Bytebase does not update the content of the corresponding issue.

Second thing I want to know is if it is possible to disable certain SQL Advise during sql review when PR is going to merge. As an example what if we have to disable advisory - bytebase.com/docs/reference/error-code/advisor#104 to warning may be & not error the Github workflow instead ?

You can follow our docs to customize your SQL Review Policy, for example, Naming Convention, Error Level.

@h3n4l
Copy link
Member

h3n4l commented May 22, 2024

Closed due to the innovative GitOps feature.

@h3n4l h3n4l closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants