Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression] CNAME with * is parsed as invalid response #457

Closed
rb-cohen opened this issue Mar 2, 2022 · 5 comments
Closed

[regression] CNAME with * is parsed as invalid response #457

rb-cohen opened this issue Mar 2, 2022 · 5 comments

Comments

@rb-cohen
Copy link

rb-cohen commented Mar 2, 2022

With a CNAME setup test -> *.test, ares is rejecting the response as invalid.

e.g.

dig test.tld

; <<>> DiG 9.10.6 <<>> test.tld
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 3826
;; flags: qr rd ra; QUERY: 1, ANSWER: 3, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 512
;; QUESTION SECTION:
;test.tld.		IN	A

;; ANSWER SECTION:
test.tld.	6529	IN	CNAME	*.test.tld.cdn.cloudflare.net.
*.test.tld.cdn.cloudflare.net. 300 IN A	1.1.1.1
*.test.tld.cdn.cloudflare.net. 300 IN A	1.1.1.1

;; Query time: 67 msec
;; SERVER: 192.168.0.1#53(192.168.0.1)
;; WHEN: Tue Mar 01 18:54:45 GMT 2022
;; MSG SIZE  rcvd: 128

Seems related to #424
Posted in node too: nodejs/node#42171
@rb-cohen rb-cohen mentioned this issue Mar 2, 2022
Closed
@bradh352
Copy link
Member

bradh352 commented Mar 2, 2022

fixed in cc79624

@bradh352 bradh352 closed this as completed Mar 2, 2022
bradh352 added a commit that referenced this issue Mar 2, 2022
@bradh352
Asterisks should be allowed in host validation as CNAMEs may referenc…
b5a3d96 
…e wildcard domains

CloudFlare appears to use this logic in CNAMEs as per
nodejs/node#42171

Fixes: #457
Fix By: Brad House (@bradh352)
@rb-cohen rb-cohen mentioned this issue Mar 4, 2022
Closed
rb-cohen pushed a commit to rb-cohen/node that referenced this issue Mar 4, 2022
@bradh352 @rb-cohen
deps: cares: cherry-pick b5a3d96
5c53341 
Original commit message:

Asterisks should be allowed in host validation as CNAMEs may reference
wildcard domains

CloudFlare appears to use this logic in CNAMEs as per
nodejs#42171

Fixes: c-ares/c-ares#457
Fix By: Brad House (@bradh352)
benjamingr pushed a commit to nodejs/node that referenced this issue Mar 13, 2022
@bradh352 @benjamingr
deps: cares: cherry-pick b5a3d96
d645315 
Original commit message:

Asterisks should be allowed in host validation as CNAMEs may reference
wildcard domains

CloudFlare appears to use this logic in CNAMEs as per
#42171

Fixes: c-ares/c-ares#457
Fix By: Brad House (@bradh352)

PR-URL: #42216
Fixes: #42171
Fixes: #457
Refs: c-ares/c-ares#457
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
bengl pushed a commit to nodejs/node that referenced this issue Mar 21, 2022
@bradh352 @bengl
deps: cares: cherry-pick b5a3d96
f2178fc 
Original commit message:

Asterisks should be allowed in host validation as CNAMEs may reference
wildcard domains

CloudFlare appears to use this logic in CNAMEs as per
#42171

Fixes: c-ares/c-ares#457
Fix By: Brad House (@bradh352)

PR-URL: #42216
Fixes: #42171
Fixes: #457
Refs: c-ares/c-ares#457
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit to danielleadams/node that referenced this issue Apr 21, 2022
@bradh352 @danielleadams
deps: cares: cherry-pick b5a3d96
1ec1ee5 
Original commit message:

Asterisks should be allowed in host validation as CNAMEs may reference
wildcard domains

CloudFlare appears to use this logic in CNAMEs as per
nodejs#42171

Fixes: c-ares/c-ares#457
Fix By: Brad House (@bradh352)

PR-URL: nodejs#42216
Fixes: nodejs#42171
Fixes: nodejs#457
Refs: c-ares/c-ares#457
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit to nodejs/node that referenced this issue Apr 24, 2022
@bradh352 @danielleadams
deps: cares: cherry-pick b5a3d96
a6e7bb3 
Original commit message:

Asterisks should be allowed in host validation as CNAMEs may reference
wildcard domains

CloudFlare appears to use this logic in CNAMEs as per
#42171

Fixes: c-ares/c-ares#457
Fix By: Brad House (@bradh352)

PR-URL: #42216
Fixes: #42171
Fixes: #457
Refs: c-ares/c-ares#457
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit to nodejs/node that referenced this issue Apr 24, 2022
@bradh352 @danielleadams
deps: cares: cherry-pick b5a3d96
652017a 
Original commit message:

Asterisks should be allowed in host validation as CNAMEs may reference
wildcard domains

CloudFlare appears to use this logic in CNAMEs as per
#42171

Fixes: c-ares/c-ares#457
Fix By: Brad House (@bradh352)

PR-URL: #42216
Fixes: #42171
Fixes: #457
Refs: c-ares/c-ares#457
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit to nodejs/node that referenced this issue Apr 24, 2022
@bradh352 @danielleadams
deps: cares: cherry-pick b5a3d96
8d734cb 
Original commit message:

Asterisks should be allowed in host validation as CNAMEs may reference
wildcard domains

CloudFlare appears to use this logic in CNAMEs as per
#42171

Fixes: c-ares/c-ares#457
Fix By: Brad House (@bradh352)

PR-URL: #42216
Fixes: #42171
Fixes: #457
Refs: c-ares/c-ares#457
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
xtx1130 pushed a commit to xtx1130/node that referenced this issue Apr 25, 2022
@bradh352 @xtx1130
deps: cares: cherry-pick b5a3d96
2cb75b6 
Original commit message:

Asterisks should be allowed in host validation as CNAMEs may reference
wildcard domains

CloudFlare appears to use this logic in CNAMEs as per
nodejs#42171

Fixes: c-ares/c-ares#457
Fix By: Brad House (@bradh352)

PR-URL: nodejs#42216
Fixes: nodejs#42171
Fixes: nodejs#457
Refs: c-ares/c-ares#457
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@nitinmohan87
Copy link

Should there be a new release tag created with this regression bug fix? I don't see this being included in the latest v1.8.1 release. Thanks!

@bradh352
Copy link
Member

This is on me. I've been slammed at work and haven't done the release prep for the new release. I'm on "vacation" this week, so I'll probably get a chance to do it :)

@nitinmohan87 nitinmohan87 mentioned this issue Dec 27, 2022
Closed
@nitinmohan87
Copy link

Hello... Any chances a new version will be released soon-ish? Thanks!

@bradh352
Copy link
Member

release prep is done, I think the target date is 1/28/2023 for the official release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rb-cohen @nitinmohan87 @bradh352