Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support some sort of span link #18

Open
c-cube opened this issue Sep 21, 2023 · 2 comments
Open

support some sort of span link #18

c-cube opened this issue Sep 21, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@c-cube
Copy link
Owner

c-cube commented Sep 21, 2023

A span (implicit or explicit) should be causally linkable to another span (or multiple other spans), either at creation time or with add_data_to_span. E.g. add ?link_to:span list -> … to add_data_to_span and span creation functions.

very useful for OTEL and streaming. See https://opentelemetry.io/docs/concepts/signals/traces/#span-links .

@c-cube c-cube added the enhancement New feature or request label Sep 21, 2023
@c-cube c-cube self-assigned this Sep 21, 2023
@ELLIOTTCABLE
Copy link
Collaborator

Honestly, I'm leaning towards user-data for this — perhaps the best option is to add a `Span span type to the user-data? instead of a new function?

that leaves exactly what semantics "referring to another span for some reason" has, up to the collector; and allows kinda 'naming' multiple other-related-spans with user-data keys.

@c-cube
Copy link
Owner Author

c-cube commented Sep 21, 2023

Interesting!! I need to think about it, but it's indeed nice to be able to say why you link to another span. Or maybe a list of span (`Span of span list). Then backends can filter this out, or make it into span links…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants