Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the state of caching on PRs #116

Open
michaelpj opened this issue May 4, 2022 · 0 comments
Open

Clarify the state of caching on PRs #116

michaelpj opened this issue May 4, 2022 · 0 comments

Comments

@michaelpj
Copy link

The README says

Pull requests do not have access to secrets so read access to a public binary cache will work, but pushing will be disabled since there is no signing key.

Here Domen suggested that it might work so long as the person making the PR has write access to the repo.

However we tried this and it didn't seem to work. So I'm unsure what the actual behaviour is.

Why do we care? In this instance we have a PR which updates a bunch of nix dependencies, and needs to do a lot of building. It would be nice if this was cached between runs on the PR. Indeed, at the moment the PR does too much building for it all to pass in one go, so we were hoping to cache it in chunks. But we can't do that if pushing to cachix in PRs doesn't work. (Of course, we could build locally and push from there, but I don't think any of us have the cachix keys!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant