-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
post step hangs indefinitely, run gets killed #170
Comments
Could you also post the log (can be in private) for the action itself? |
Sure :)
|
@katexochen, v14 runs a daemon to push things in the background. We've fixed a few edge-cases where it wouldn't shut down properly and caused similar issues in CI runs. You can try using cachix from our master branch. We'll get a release out soon. - uses: cachix/cachix-action@18cf96c7c98e048e10a83abd92116114cd8504be
with:
name: edgelesssys
installCommand: nix profile install github:cachix/cachix/cd12acd9245ac9b7e010aa3acac49f37824fdad2 --accept-flake-config |
See cachix/cachix-action#170 Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
See cachix/cachix-action#170 Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
@sandydoo this still seems to be an issue on the commit you pointed me to:
|
@katexochen, are there any logs from the post-run step? If it is the daemon causing this, you can set |
No logs, after canceling it just says:
|
@katexochen could you schedule a call via https://cal.com/domenkozar so we look into this? |
You can also set a timeout for the step: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepstimeout-minutes |
I am observing the same thing on v14. Here are some logs: Setting up cachix:
Post cleanup:
|
Waiting for 1.7.1 bump here: NixOS/nixpkgs#291275 |
Btw I had to remove this, as it not only didn't fix the problem but also stopped pushing paths at all. |
@katexochen, thanks for the update. I'm trying to reproduce this. |
@katexochen could you try master, this should be fixed now:
|
or @wolfgangwalther :) |
On my list, but didn't get to it, yet. |
I've updated to 3a6e4a049f7cadd8894015c2488a2fa969c83c41. ✔️ |
How are things looking? |
Seems to work fine, paths are pushed, no hanging until now. |
Same here. This did not happen with every run before, so hard to tell - but since I updated cachix, it didn't happen again, yet. |
Thanks guys! Please reopen if you see it happen again. |
I can't reopen the issue myself, but issue occurred again on the previously mentioned pinned commit. Run cachix/cachix-action@1 8cf96c7c98e048e10a83abd92116114cd8504be
|
Observed another two hangers today. Not sure what changed (as the cachix install is pinned) but seems to occur more often now. |
And another one: post step output
|
I am also experiencing this on
|
What are you using for the installCommand? The fix is in cachix itself, not in cachix-action. |
I still have 3a6e4a049f7cadd8894015c2488a2fa969c83c41 pinned. |
I am using this for my install command: - name: Install Nix
uses: cachix/install-nix-action@v26
with:
nix_path: nixpkgs=channel:nixos-23.11 Edit: After re-reading the last several comments, I have realized that I have misinterpreted the proposed fix. |
I should also note that I added a timeout to this step so that it wouldn't go unnoticed for several hours. Here are my logs for a recent failure. Setup
Post Step
Please let me know if there is anything more useful I can provide. |
We're going to wire up the debugging info and ask you to use that so we better understand what's going on. Thank you guys :) |
Still an issue, and occurs quite often within the last month. Any update? |
@katexochen, could you please give |
They are still trying to fix the endless hang in the post step, see cachix/cachix-action#170 (comment) Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
They are still trying to fix the endless hang in the post step, see cachix/cachix-action#170 (comment) Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
@sandydoo still observing hangs on this commit (maybe a bit less frequent). |
Are there any commonalities between affected setups? E.g. anyone using |
I managed to get a reliable-ish repro for this. I've been running it against devenv's CI on a mix of hosted and self-hosted machines with good results. branch: https://github.com/cachix/cachix/commits/debug-daemon-stop/ - uses: cachix/cachix-action@master
with:
name: <CACHE_NAME>
installCommand: nix profile install github:cachix/cachix/debug-daemon-stop -L --accept-flake-config |
@sandydoo I didn't observe any problems since updating to this commit two weeks ago. |
@katexochen, epic! I've been dogfooding this across our org with good results as well. We're prepping a new release. |
Released 1.7.3 with the fix, please reopen if it still happens! |
We've observed this multiple times now. Sometimes the post step of the action hangs indefinitely so that the workflow would finally get killed.
This is using v14 of the action (hash-pinned).
The text was updated successfully, but these errors were encountered: