Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling rollback on activation failure #610

Open
philon123 opened this issue Dec 22, 2023 · 0 comments
Open

Allow disabling rollback on activation failure #610

philon123 opened this issue Dec 22, 2023 · 0 comments
Labels
deploy enhancement New feature or request

Comments

@philon123
Copy link

deploy-rs allows to use a flag --auto-rollback false, which will ignore any systemd errors while activating a deployment.

That can make sense in certain cases, for example when upgrading kubnernetes. Kubernetes relies on several unts that have racy dependencies to each other, so we need to ignore errors when restarting all units at once. The races resolve after a couple seconds.

Another example in our project is that services might break for reasons unrelated to the deployment. For example, some certificate managing service might fail because a DNS entry was changed. In this case, we may want to ignore this failing service becasue it's irrelevant to the deployment.

I suggest introducing the same --auto-rollback false flag in cachix deploy.

@sandydoo sandydoo added enhancement New feature or request deploy labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants