Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: hook for flynt, configuration for pyupgrade #238

Open
arjan-s opened this issue Feb 6, 2023 · 3 comments
Open

Feature request: hook for flynt, configuration for pyupgrade #238

arjan-s opened this issue Feb 6, 2023 · 3 comments
Labels
new-hook A request for a new hook

Comments

@arjan-s
Copy link

arjan-s commented Feb 6, 2023

Examples from my current .pre-commit-config.yaml:

repos:
  - repo: https://github.com/asottile/pyupgrade
    rev: v3.3.1
    hooks:
      - id: pyupgrade
        args: [--py310-plus]
        exclude: /migrations/
  - repo: https://github.com/pre-commit/mirrors-mypy
    rev: v0.991
    hooks:
      - id: mypy
        additional_dependencies: ['types-requests', 'types-python-dateutil', 'types-pytz']
        exclude: /migrations/
  - repo: https://github.com/ikamensh/flynt/
    rev: '0.77'
    hooks:
      - id: flynt
        exclude: /migrations/
@domenkozar domenkozar added the new-hook A request for a new hook label Jul 29, 2023
@totoroot
Copy link
Collaborator

mypy and pyupgrade are already available, so really this issue is just a request for flynt. Maybe we should update the issue title.

@arjan-s
Copy link
Author

arjan-s commented Sep 11, 2023

The mypy hook works well, but the pyupgrade hook doesn't allow to define the target Python version, so it's not very usable.

@arjan-s arjan-s changed the title Feature request: hooks for mypy, pyupgrade and flynt Feature request: hook for flynt, configuration for pyupgrade Sep 11, 2023
@totoroot
Copy link
Collaborator

Alright, thanks for clarifying. I'll take a look later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-hook A request for a new hook
Projects
None yet
Development

No branches or pull requests

3 participants