Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C/C++ hooks: cppcheck and include-what-you-use #275

Open
edrex opened this issue Apr 12, 2023 · 2 comments
Open

C/C++ hooks: cppcheck and include-what-you-use #275

edrex opened this issue Apr 12, 2023 · 2 comments
Labels
new-hook A request for a new hook

Comments

@edrex
Copy link

edrex commented Apr 12, 2023

I'm setting up CI for a C/C++ project at alex-courtis/way-displays#86. cppcheck and include-what-you-use are used, and I want to add pre-commit hooks for them.

There is an existing hooks repo that has these at https://github.com/pocc/pre-commit-hooks. The runner scripts are python 3. Does that disqualify them (python3 in nixpkgs has a 131MB closure), or is python3 already pulled in elsewhere?

Otherwise, what would be an ideal way, from the pre-commit-hooks.nix project perspective, to add these? I could just do local hooks for them, but I'd rather get it contributed up.

Thanks!

@edrex
Copy link
Author

edrex commented Apr 12, 2023

python3 in nixpkgs has a 131MB closure

Looks like there is python3Minimal with 57.5MB closure size.

@domenkozar domenkozar added the new-hook A request for a new hook label Jul 29, 2023
@domenkozar
Copy link
Member

If we can use python3minimal that would be great, note that it doesn't have the openssl (which should be fixed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-hook A request for a new hook
Projects
None yet
Development

No branches or pull requests

2 participants