New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Bookmarklet Maker should strip JavaScript code comments first #3

Open

TechAurelian2 opened this issue Aug 11, 2023 · 1 comment

TechAurelian2 commented Aug 11, 2023

For the following code:

// Show an alert window
alert('hello world');

I get a the following bookmarklet output:

javascript:(function()%7B%2F%2F%20Show%20an%20alert%20window%0Aalert('hello%20world')%3B%7D)()%3B

but I think the JavaScript comments should be removed, and get

javascript:(function()%7Balert('hello%20world')%3B%7D)()%3B

VillainsRule mentioned this issue

Closed

VillainsRule commented Aug 12, 2023

@TechAurelian fixed in #4
this repo is fully unmaintained so I doubt it'll be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment