Can't get it to run. #39
Comments
|
I am not familiar with CodeShip, sorry. |
|
My concrete problem is, that we are using typescript. This is my Karma.conf.js and it is just scanning my polyfills.js for coverage: Coverall is only testing my test.ts or my polyfills.js, nothing else, could be misconfig in my test.ts ? |
|
I mean, I really don't have the answer to this question :( this project sort of predated adoption of TypeScript, from the angular 1.x days. I haven't had the opportunity or need to adapt it to TypeScript just yet. If you've gotten anywhere with integrating it, I would love it if you could send a pull request (and hopefully some tests to demonstrate that it's doing the right thing correctly, maybe some doc updates for typescript users). I know it's been a while since this issue was opened, but if anybody else looking at this has time to chip in and make it happen, that would be amazing. |
|
Our Software Testers can't code. Our Developers don't write tests. Our Project Managers have no idea of TDD. Therefore we learned to live with bugs in production and fixing production on a constant emergency basis like von Papen did before Hitler took over. Cheers. |
|
well alright then, leaving this open in case anybody else has a similar problem and can stand to submit a fix. |
|
its a bit of a beast, but you can see a working TypeScript implementation that generates coverage reports here. https://github.com/Esri/arcgis-rest-js/blob/master/karma.conf.js |
|
For me it causes Chrome to throw an exception when running Karma. Testing works if I don't include the 'coveralls' reporter, but when I add it as instructed in the yaml, I get the following:
|
|
@MarkPThomas just for fun, try applying the following diff and lets see if it works after that --- if it does, can you send a pull request with the change applied? diff --git a/lib/index.js b/lib/index.js
index e7dfe44..104a2e7 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -5,7 +5,8 @@ var through2 = require('through2');
var lcovResultMerger = require('lcov-result-merger');
var coveralls = require('coveralls');
-var CoverallsReporter = function(rootConfig, helper, logger) {
+var CoverallsReporter = function(initBaseReporter, rootConfig, helper, logger) {
+ initBaseReporter(this);
var log = logger.create('coveralls.io');
var config = rootConfig.coverallsReporter || {};
var reporters = (rootConfig.reporters || []);
@@ -137,7 +138,7 @@ var CoverallsReporter = function(rootConfig, helper, logger) {
}
};
-CoverallsReporter.$inject = ['config', 'helper', 'logger'];
+CoverallsReporter.$inject = ['baseReporterDecorator', 'config', 'helper', 'logger'];
module.exports = {
'reporter:coveralls': ['type', CoverallsReporter] |
|
@caitp
It looks like it should be working. Strange...
I can see that reporters is coming in as |
|
whats the intellij thing coming from? Nvm, you said PhpStorm.. hmm. Still, seems like its being mutated along the way somewhere. Maybe there’s a way to get the plugin name programmatically in case it’s mutated? If there is, we should do that. |
|
I think it will work in this case if you change it to a If we can’t figure out the renaming thing, that should work in your case |
caitp
added
the
help-wanted
Hi thanks for your work on this plugin. I now installed the plugin and sent my built to codeship and also let Karma run beforehand locally, but I dont see any coverage generated. I do not have Mocha, this is a Ionic3/Angular4 project employing only Karma. Do you have an example config for use with Karma (and Codeship)?
The text was updated successfully, but these errors were encountered: