Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up publishing on Conda #178

Open
eliotwrobson opened this issue Oct 23, 2023 · 4 comments
Open

Set up publishing on Conda #178

eliotwrobson opened this issue Oct 23, 2023 · 4 comments

Comments

@eliotwrobson
Copy link
Collaborator

eliotwrobson commented Oct 23, 2023

In a lead-up to the PyOpenSci review, one of the suggestions from them is to publish the package on conda-forge as well as PyPI, which I think is generally a good idea. Details from their packaging guide is here: https://www.pyopensci.org/python-package-guide/package-structure-code/publish-python-package-pypi-conda.html#how-to-submit-to-conda-forge

@caleb531 what are your feelings about this?

@caleb531
Copy link
Owner

@eliotwrobson In principle, I would prefer any publishing processes to be automated via GitHub Actions (like how it is currently with the PyPI publishing based on new tags).

Fortunately, based on the documentation you linked to, it seems that after the initial peer-reviewed publish, the conda-forge CI will take over the publishing process for the most part (besides the final merging of the CI-generated PR that seems like the only manual step for these subsequent releases).

For these future manual steps, I should mention that we would need to update the Release Checklist with instructions on this. Perhaps we can configure the package on conda-forge to allow you to merge as well (and not just me as the owner of the upstream repository).

What do you think?

@eliotwrobson
Copy link
Collaborator Author

For these future manual steps, I should mention that we would need to update the Release Checklist with instructions on this. Perhaps we can configure the package on conda-forge to allow you to merge as well (and not just me as the owner of the upstream repository).

That sounds reasonable. Giving me the merge ability as well would be good I think. Even though I haven't done a deploy yet, it would be nice to have the ability to do so if something small comes up. Either way, I think having this mostly automated will have pretty minimal overhead compared to the benefit of having this published in more places.

@caleb531
Copy link
Owner

caleb531 commented Oct 23, 2023

@eliotwrobson Okay, sounds good! Would you please be able to get the process started by forking the conda-forge repository, using grayskull, and submitting a PR? I assume it would be fine for a non-owner to submit the PR as long as they are still a maintainer/collaborator (which you are).

EDIT: Never mind—I just remembered we need to get the new documentation site up and running first. 🤦🏻‍♂️

@eliotwrobson
Copy link
Collaborator Author

@caleb531 I think the order doesn't really matter here, but I agree that I think it makes sense to do this after getting the new docs set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants