fix(babel): lookup referencedIdentifiers after tree mutations (#1180)

* fix: lookup referencedIdentifiers after tree mutations * fix(babel): lookup referencedIdentifiers after tree mutations (fixes #1112) --------- Co-authored-by: Victor Lin <victor.lin@airbnb.com> Co-authored-by: Anton Evzhakov <anton@evz.name>
callstack · Feb 6, 2023 · 61d49a3 · 61d49a3
1 parent 4dd089c
commit 61d49a3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/.changeset/yellow-cougars-invite.md b/.changeset/yellow-cougars-invite.md
@@ -0,0 +1,6 @@
+---
+'@linaria/utils': patch
+'@linaria/babel-preset': patch
+---
+
+Fix for #1112 "Cannot read properties of undefined (reading 'localeCompare')"
diff --git a/packages/utils/src/scopeHelpers.ts b/packages/utils/src/scopeHelpers.ts
@@ -369,6 +369,10 @@ function removeWithRelated(paths: NodePath[]) {
   const affectedPaths = actions.map(getPathFromAction);
 
   let referencedIdentifiers = findIdentifiers(affectedPaths, 'referenced');
+  referencedIdentifiers.sort((a, b) =>
+    a.node?.name.localeCompare(b.node?.name)
+  );
+
   const referencesOfBinding = findIdentifiers(affectedPaths, 'binding')
     .map((i) => (i.node && getScope(i).getBinding(i.node.name)) ?? null)
     .filter(isNotNull)
@@ -391,10 +395,6 @@ function removeWithRelated(paths: NodePath[]) {
 
   removeWithRelated(referencesOfBinding);
 
-  referencedIdentifiers.sort((a, b) =>
-    a.node?.name.localeCompare(b.node?.name)
-  );
-
   let clean = false;
   while (!clean && referencedIdentifiers.length > 0) {
     const referenced = removeUnreferenced(referencedIdentifiers);