Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@linaria/shaker: export * is removed for TS #820

Closed
layershifter opened this issue Aug 16, 2021 · 0 comments · Fixed by microsoft/fluentui#20108
Closed

@linaria/shaker: export * is removed for TS #820

layershifter opened this issue Aug 16, 2021 · 0 comments · Fixed by microsoft/fluentui#20108
Assignees
@Anber
Labels
bug report 🦗 Issue is probably a bug, but it needs to be checked cat: typings 👮 Typescript types related issues needs: complete repro 🖥️ Issue need to have complete repro provided

Comments

@layershifter
Copy link
Contributor

Environment

  • Linaria version: @linaria/shaker@3.0.0-beta.11
  • Bundler (+ version): N/A
  • Node.js version: 12.14
  • OS: Windows 10

Description

Similar to #808. I am considering this an edge case, not sure that it should be fixed.

  • contains import of memoizeFunction
  • evaluation is turned on for node_modules
❯ node using-babel.js
fixtureName failing
exports['foo'] function

❯ node using-shaker.js 
TypeError: _utilities.memoizeFunction is not a function
    at eval (/home/projects/node-77dfmk/src/failing/index.js:9:39)
    at eval (/home/projects/node-77dfmk/src/failing/index.js:13:3)

This happens because shaker does not how to handle code compiled by TS:

"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
var tslib_1 = require("tslib");

tslib_1.__exportStar(require("./memoize"), exports);

https://cdn.jsdelivr.net/npm/@fluentui/utilities@8.2.2/lib-commonjs/index.js

Reproducible Demo

https://stackblitz.com/edit/node-77dfmk
@layershifter layershifter added bug report 🦗 Issue is probably a bug, but it needs to be checked needs: complete repro 🖥️ Issue need to have complete repro provided needs: triage 🏷 Issue needs to be checked and prioritized labels Aug 16, 2021
@github-actions github-actions bot added cat: typings 👮 Typescript types related issues and removed needs: triage 🏷 Issue needs to be checked and prioritized labels Aug 16, 2021
@Anber Anber self-assigned this Sep 11, 2021
Anber added a commit that referenced this issue Sep 12, 2021
@Anber
fix(shaker): partial support for ts compiled code (fixes #820)
cce17c1
@Anber Anber mentioned this issue Sep 12, 2021
Merged
@Anber Anber closed this as completed in ec8ee68 Sep 12, 2021
ling1726 added a commit to ling1726/fluentui that referenced this issue Oct 5, 2021
@ling1726
fix(babel-make-styles): Bump Linaria versions
1348019 
Bump linaria versions to consume fix callstack/linaria#820
@ling1726 ling1726 mentioned this issue Oct 5, 2021
Merged
2 tasks
layershifter pushed a commit to microsoft/fluentui that referenced this issue Oct 5, 2021
@ling1726
fix(babel-make-styles): Bump Linaria versions (#20108)
c41b8f8 
* fix(babel-make-styles): Bump Linaria versions

Bump linaria versions to consume fix callstack/linaria#820

* Change files
mlp73 pushed a commit to mlp73/fluentui that referenced this issue Jan 17, 2022
@ling1726
fix(babel-make-styles): Bump Linaria versions (microsoft#20108)
1f87838 
* fix(babel-make-styles): Bump Linaria versions

Bump linaria versions to consume fix callstack/linaria#820

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anber Anber

Labels
bug report 🦗 Issue is probably a bug, but it needs to be checked cat: typings 👮 Typescript types related issues needs: complete repro 🖥️ Issue need to have complete repro provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(babel-make-styles): Bump Linaria versions ling1726/fluentui
2 participants
@Anber @layershifter