-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Having to use an empty act
immediately after render to avoid warning
#1066
Comments
@leepowellnbs can you post a minimal repro repository that showcases the issue & fix? |
@mdjastrzebski sure I'll try to pull one together - I was trying to do so yesterday when I came across this strange behaviour #1067 |
@leepowelldev could you check if this issue still occurs with RNTL v11.2.0? |
I'm also seeing this issue in RNTL v9.1.0 with Jest 26.6.3 after upgrading to RN 0.69 (using Expo SDK 46). I don't mean to hijack this discussion - let me know if this warrants discussion and another ticket. We've previously moved away from queries like Is there a workaround for older versions of RNTL? I'm unable to upgrade at the moment thanks to a package using RN Reanimated. |
That's going to be complicated, because RN 0.69 comes with react 18 which uses a different model for Regarding you RN reanimated issue, could a global mock work? |
That's what I was afraid of. I'll move forward with using this |
Closing as original issue hasn't seen any action since August. @leepowellnbs if the issue still occurs to you pls create a new issue with minimal repro repo based on our @jake-carpenter Pls create a separate issue with minimal repro repo if needed. |
I have a component, which does some async loading of data from various sources - some coming from within the component itself, and some coming from a wrapped context - all take place in
useEffect
hooks. I'm finding I'm having to use emptyact
calls to avoid theact
warning - contrived example:In this example I get the "not wrapped in an act" warning from where one of the context providers is fetching data on mount. The odd thing, is the component doesn't render
Hello
until this data fetching is finished and the fetched data is available.To suppress the error I am having to add an empty
act
:I have no idea why but this seems to work. Could anyone help me understand why this works, or if there is a better way of doing this - as it feels a bit hacky. Thanks.
EDIT: Just remembered, the data loading function called by the provider is async - and once the data resolves it sets state, which is what is seemingly triggering the act warning.
The text was updated successfully, but these errors were encountered: