Implement toHaveAccessibilityValue matcher #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunrajput
changed the title
19 tasks
tarunrajput
force-pushed
the
feat/add-toHaveAccessibilityValue-matcher
branch
from
c46061c
to
61626bc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1496 +/- ##
==========================================
+ Coverage 98.13% 98.15% +0.01%
==========================================
Files 97 98 +1
Lines 5747 5787 +40
Branches 890 894 +4
==========================================
+ Hits 5640 5680 +40
Misses 107 107
☔ View full report in Codecov by Sentry. |
pierrezimmermannbam
suggested changes
Sep 18, 2023
There was a problem hiding this comment.
@tarunrajput Thanks for the pr! Implementation looks good, I just have some feedback on the tests that needs to be addressed before we merge this
mdjastrzebski
force-pushed
the
feat/add-toHaveAccessibilityValue-matcher
branch
3 times, most recently
from
4c0df36
to
3848c5e
Compare
mdjastrzebski
force-pushed
the
feat/add-toHaveAccessibilityValue-matcher
branch
from
3848c5e
to
ebcbab5
Compare
mdjastrzebski
approved these changes
Oct 25, 2023
|
🎉 Release in version: v12.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#1485 - Implement
toHaveAccessibilityValuematcherTest plan
Add unit tests and ensure all test passes