Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid hardcoding sampling rate #28

Open
Ashoat opened this issue Sep 3, 2019 · 2 comments
Open

Avoid hardcoding sampling rate #28

Ashoat opened this issue Sep 3, 2019 · 2 comments

Comments

@Ashoat
Copy link
Member

Ashoat commented Sep 3, 2019

Instead of hardcoding a specific sampling rate, we should pull the sampling rate from the audio device we're using. #14 was a first attempt at this, but I want to fix it up to avoid setting the sampling rate to a static variable

@revbucket
Copy link
Contributor

Commenting so I can get notified about this when progress is being made. Pending the resolution of the
madmom timing issues, it's a nearly trivial fix to ensure that the pyAudio/portAudio stream is opened under the desired sampling rate.

@Ashoat
Copy link
Member Author

Ashoat commented Sep 5, 2019

You can actually subscribe to updates on an issue by pressing the “Subscribe” button. As for Madmom sampling rate - unless there is a bug in how Madmom works, I don’t think there’s any reason that it needs to have the same sampling rate as Spectrum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants