Default metrics provided by spring-boot-actuator don't work

[chillleader]

Issue description

MetricsRecorder bean declaration in spring-zeebe-starter breaks the default metrics auto configurations provided by Spring Boot Actuator.

spring-zeebe/client/spring-zeebe-starter/src/main/java/io/camunda/zeebe/spring/client/actuator/ZeebeActuatorConfiguration.java

Line 23 in 47e1513

public MetricsRecorder micrometerMetricsRecorder(

Apparently, the MeterRegistry bean is eagerly injected, which breaks the initialization of other metrics. As a result, for, example, the jvm metrics are missing in the actuator endpoint:

Possible solution

• Inject MeterRegistry bean with @Lazy

Similar issues with example solutions:

• Some metrics are lost when Spring Data is on the classpath spring-projects/spring-boot#26630
• https://stackoverflow.com/questions/52148543/spring-boot-2-actuator-doesnt-publish-jvm-metric/53119998#53119998

[berndruecker]

Awesome - can you provide a PR @chillleader or is this something we should give more thouht?

Feeling-wise, the whole auto configuration could be worth to have a concentrated look when doing #275

[chillleader]

Yes, I can provide an immediate fix by adding @Lazy and maybe also take a concentrated look at this later while working on the new connector metrics.

[berndruecker]

great stuff - from my perspective we can close this for now - I made a remark in #275 to have another look at it then

[chillleader]

I encountered this again in 8.2.0-alpha1.

[berndruecker]

I can have a look at it - I think I have ideas why. Thanks for raising it!

[berndruecker]

Ok - after trying out different things I have to confess I don't fully understand the problem ;-)

The fix proposed in spring-projects/spring-boot#26684 also works for us, so if I add the following configuration, I have all metrics back - even without @Lazy.

  @Bean
  InitializingBean forceMeterRegistryPostProcessor(BeanPostProcessor meterRegistryPostProcessor, MeterRegistry registry) {
    return () -> meterRegistryPostProcessor.postProcessAfterInitialization(registry, "");
  }

There were further quite some discussions/problems with such things with various Spring Boot 2.x versions. My proposal is that we simply apply this workaround and do not try to understand the big picture fully.

[berndruecker]

[berndruecker]

@chillleader Can you probably double check with latest main? Should be fixed with 1603539

[chillleader]

Works like a charm ⭐ Thank you Bernd.
I'm also fine with this workaround.

[445990772]

i have the same problem,
spring-boot version : 2.7.8

when I debuged MeterRegistryPostProcessor#postProcessAfterInitialization,
debuger not jump into if(bean instance of MeterRegistry) ，then i found jvmMetrics does not bind to PrometheusMeterRegistry

then i try to solve the problem with this , but it doesn't works ,MeterRegistryPostProcessor can not be imported cause it's not public
what else can i do ?

Btw. for anyone else having this issue, this fixes it for now:

@configuration
public class FixPrometheusMetrics {
public FixPrometheusMetrics(MeterRegistryPostProcessor postProcessor, PrometheusMeterRegistry registry) {
postProcessor.postProcessAfterInitialization(registry, "");
}
}