Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monkey patch 5.1 styles for the release, then resolve those. #3025

Closed
5 tasks done
Skaiir opened this issue Jul 12, 2022 · 5 comments
Closed
5 tasks done

Monkey patch 5.1 styles for the release, then resolve those. #3025

Skaiir opened this issue Jul 12, 2022 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Jul 12, 2022

Describe the bug

We've encountered two release critical bugs late in the release, we'll fix this temporarily using css styling but the root cause needs to be investigated for both of those and the monkey patch reverted.

Steps to reproduce

CSS issue:

  1. using camunda-modeler 5.1.0-rc.2
  2. open a bpmn diagram
  3. create a task
  4. look at the template section => button is not visible except on hover due to styles override

Sticky header issue:

  1. using camunda-modeler 5.1.0-rc.2
  2. open a bpmn diagram
  3. mess around with the group headers => headers sometimes end up in an unexpected state

Expected behavior

The template buttons should always be visible if the group is present.

The headers should only be sticky when they are at least partially above the top of the scrollarea.

Environment

  • Camunda Modeler Version: 5.1.0-rc.2

Additional context

No response

@Skaiir Skaiir added the bug Something isn't working label Jul 12, 2022
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jul 12, 2022
Skaiir added a commit that referenced this issue Jul 12, 2022
Skaiir added a commit that referenced this issue Jul 12, 2022
Skaiir added a commit that referenced this issue Jul 12, 2022
Skaiir added a commit that referenced this issue Jul 12, 2022
@pinussilvestrus
Copy link
Contributor

Also related: #3030

@pinussilvestrus
Copy link
Contributor

[fyi] The tasks

are done via #3031.

@Skaiir Skaiir assigned pinussilvestrus and unassigned Skaiir Jul 28, 2022
@pinussilvestrus
Copy link
Contributor

Root cause and fix bpmn-io/bpmn-js-properties-panel#726

Find some notes on this one: bpmn-io/bpmn-js-properties-panel#726 (comment)

@pinussilvestrus
Copy link
Contributor

This is fixed upstream as it requires the integration of a new properties panel release.

@pinussilvestrus pinussilvestrus added fixed upstream Requires integration of upstream change and removed in progress Currently worked on labels Jul 29, 2022
@pinussilvestrus pinussilvestrus added this to the M55 milestone Aug 3, 2022
@philippfromme
Copy link
Contributor

Closed via #3059.

@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants