Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After restoring from backup, a partition re-takes the backup #12623

Closed
deepthidevaki opened this issue May 2, 2023 · 0 comments · Fixed by #12626
Closed

After restoring from backup, a partition re-takes the backup #12623

deepthidevaki opened this issue May 2, 2023 · 0 comments · Fixed by #12626
Assignees
@deepthidevaki
Labels
kind/bug Categorizes an issue or PR as a bug version:8.2.5 Marks an issue as being completely or in parts released in 8.2.5 version:8.3.0-alpha2 Marks an issue as being completely or in parts released in 8.3.0-alpha2 version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0

Comments

@deepthidevaki
Copy link
Contributor

Describe the bug

After restoring from backup, if the leader that took the original backup is no more the leader of the partition, this can result in a duplicate backup of the partition with the same backup id. The new backup is logically equivalent to the old backup. So it doesn't matter which backup we use later. However, re-taking the backup is unnecessary as it wastes resources.

To Reproduce
Restore zeebe from a backup, and observe the logs or inspect the backup store.

Expected behavior
A partition should not re-take a backup after restore.
@deepthidevaki deepthidevaki added the kind/bug Categorizes an issue or PR as a bug label May 2, 2023
@deepthidevaki deepthidevaki self-assigned this May 2, 2023
@deepthidevaki deepthidevaki mentioned this issue May 2, 2023
Merged
14 tasks
@backport-action backport-action mentioned this issue May 3, 2023
Merged
zeebe-bors-camunda bot added a commit that referenced this issue May 3, 2023
@zeebe-bors-camunda @deepthidevaki
merge: #12656
958668f 
12656: [Backport stable/8.2] fix: do not retake backup if it already exists r=deepthidevaki a=backport-action

# Description
Backport of #12626 to `stable/8.2`.

relates to #12623

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@users.noreply.github.com>
@deepthidevaki deepthidevaki mentioned this issue May 4, 2023
Merged
zeebe-bors-camunda bot added a commit that referenced this issue May 4, 2023
@zeebe-bors-camunda @deepthidevaki
merge: #12662
67b98e6 
12662: [Backport stable/8.1] fix: do not retake backup if it already exists r=oleschoenburg a=deepthidevaki

Backport of #12626 to stable/8.1.

relates to #12623

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@users.noreply.github.com>
zeebe-bors-camunda bot added a commit that referenced this issue May 4, 2023
@zeebe-bors-camunda @deepthidevaki @aivinog1
merge: #12662 #12665
f16558d 
12662: [Backport stable/8.1] fix: do not retake backup if it already exists r=deepthidevaki a=deepthidevaki

Backport of #12626 to stable/8.1.

relates to #12623

12665: [Backport stable/8.1] refactor(snapshots): Replace `Stream.toList` and the for each cycle to `Stream.forEachOrdered` r=deepthidevaki a=backport-action

# Description
Backport of #12576 to `stable/8.1`.

relates to #12575

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@users.noreply.github.com>
Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
@oleschoenburg oleschoenburg added the version:8.2.5 Marks an issue as being completely or in parts released in 8.2.5 label May 16, 2023
@oleschoenburg oleschoenburg added the version:8.3.0-alpha2 Marks an issue as being completely or in parts released in 8.3.0-alpha2 label Jun 7, 2023
@megglos megglos added the version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0 label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepthidevaki deepthidevaki

Labels
kind/bug Categorizes an issue or PR as a bug version:8.2.5 Marks an issue as being completely or in parts released in 8.2.5 version:8.3.0-alpha2 Marks an issue as being completely or in parts released in 8.3.0-alpha2 version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not retake backup if it already exists camunda/zeebe
3 participants
@megglos @oleschoenburg @deepthidevaki