Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create incidents to avoid blacklisted instances #5123

Closed
Zelldon opened this issue Aug 6, 2020 · 2 comments
Closed

Create incidents to avoid blacklisted instances #5123

Zelldon opened this issue Aug 6, 2020 · 2 comments
Assignees
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog

Comments

@Zelldon
Copy link
Member

Zelldon commented Aug 6, 2020

Description

If a workflow instance is blacklisted, then this instance can't be used anymore. To avoid that we should try to create incident before that happens. We do this for example before job activation, if we realize that we are not able to activate the job, since it has to large variables (#4420).

There exist several other places where and how this can happen. For example in one of our last game days we accumulated variables together and at some point the workflow instance get stuck. It was blacklisted, because we were not able to write the next variable record. See the game day summary https://confluence.camunda.com/display/ZEEBE/Game+Day+05.08.2020.
If we would write an incident before this would make it possible for the user to react and solve the issue and he will not lose his workflow instance and the related data.

Another example is multi-instance, we still have the issue that we are not able to create large multi instances #2890. We will blacklist the instance quite easy, but this means the user is not able to resolve it. If we would create an incident before, the user can adjust the collection which is used to create the multi instance. It makes the system more usable.

Blacklisting should only be used to prevent bugs to cause more issues, but if we know limitations of the system then we should handle them properly.

@Zelldon Zelldon added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog Impact: Usability labels Aug 6, 2020
@npepinpe
Copy link
Member

npepinpe commented Aug 6, 2020

Please write separate issues for the concrete cases we know of. In general though I like this a lot, raising an incident before an error occurs greatly improves the user experience.

Please close after the new issues are created.

@Zelldon
Copy link
Member Author

Zelldon commented Aug 21, 2020

@Zelldon Zelldon closed this as completed Aug 21, 2020
@KerstinHebel KerstinHebel removed the blocker/info Marks an issue as blocked, awaiting more information from the author label Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog
Projects
None yet
Development

No branches or pull requests

3 participants