Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not retake backup if it already exists #12626

Merged
merged 3 commits into from May 3, 2023
Merged

fix: do not retake backup if it already exists #12626

merged 3 commits into from May 3, 2023

Commits on May 2, 2023

  1. fix(backup): do not take backup when one already exists 

    Previously, we were only checking for backups taken by this node.
However, there could be backups taken by another node. For example, after
restore the checkpoint record is processed again, but it must not re-take
the backup. To prevent that, we should check for all backups with the given
backup id.
    @deepthidevaki
    deepthidevaki committed May 2, 2023
    Configuration menu
    Copy the full SHA
    a886d80 View commit details
    Browse the repository at this point in the history

  2. test(backup): verify backup is not re-taken when already exist 

    Updated the test to remove mocking of InProgressBackup. The existing test
was updated to use list instead of getStatus to find duplicate backups.
    @deepthidevaki
    deepthidevaki committed May 2, 2023
    Configuration menu
    Copy the full SHA
    8763717 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. refactor(backup): use existing comparator 

    Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
    @deepthidevaki @oleschoenburg
    deepthidevaki and oleschoenburg committed May 3, 2023
    Configuration menu
    Copy the full SHA
    65e08d9 View commit details
    Browse the repository at this point in the history