Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport stable/8.0] Fix flaky EmbeddedSubProcessTest #12721

Merged
merged 1 commit into from May 10, 2023

Conversation

remcowesterhoud
Copy link
Contributor

Description

Backport of #12697 to stable/8.0.

relates to #11844

The test was flaky because it could occur that the messages got published before the subscription were opened.
As the messages have no TTL this means they were not getting correlated, as expected.
@remcowesterhoud
Copy link
Contributor Author

@koevskinikola I had to manually backport this one because the test was moved to a different class. The changes are exactly the same though.

Copy link
Member

@koevskinikola koevskinikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

bors merge

@koevskinikola koevskinikola changed the title [Backport stable/8.2] Fix flaky EmbeddedSubProcessTest [Backport stable/8.0] Fix flaky EmbeddedSubProcessTest May 9, 2023
@koevskinikola
Copy link
Member

bors r+

@remcowesterhoud
Copy link
Contributor Author

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 4494294 into stable/8.0 May 10, 2023
25 checks passed
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the backport-12697-to-stable/8.0 branch May 10, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants