New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport stable/8.1] Support large input collections for Multi-instance #12742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verifies that a multi instance with a large input collection can activate all it's children without running out of batch size. The test also verifies that batching is used for the activating. (cherry picked from commit 4c7f25a)
Improves the assertion message by explaining what the next steps are if it fails. (cherry picked from commit de94cff)
Adds the ActivateProcessInstanceBatchProcessor and registers it with the Engine. This processor is responsible to handle the ProcessInstanceBatch.ACTIVATE commands. It is used for activating child element instance of a multi instance element in a batch-like manner. The index in the command is used to indicate how much children need to be activated. If the amount of children will exceed the max message size a followup batch command is written. The index of the followup command is decremented for each of the activate commands that have been send. (cherry picked from commit ddd34ad)
A batch ACTIVATE operation works different from a TERMINATE batch operation. During a TERMINATE the index is the key of a child element instance. For ACTIVATE it is a simple counter, keeping track of how many ACTIVATE commands we still need to write. (cherry picked from commit 307c083)
Instead of writing all the ACTIVATE commands for all children at once, we now use the ProcessInstanceBatch.ACTIVATE command instead. This command takes an index, which in this case is the amount of children that an ACTIVATE command will be written for. (cherry picked from commit 65988a2)
14 tasks
remcowesterhoud
approved these changes
May 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Build failed: |
bors retry |
Build failed: |
Resolves compilation issues caused by classes that have been moved in later versions, as well as the bpmnEventType which was introduced on the ProcessInstanceRecord in 8.2.
bors merge |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #12692 to
stable/8.1
.relates to #2890