Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move user command backpressure to log stream module #18368

Merged
merged 26 commits into from
May 22, 2024

Conversation

oleschoenburg
Copy link
Member

@oleschoenburg oleschoenburg commented May 8, 2024

Description

User command backpressure used to be implemented in CommandApiRequestHandler. This PR moves it to the log stream module.

Backpressure is still configurable via zeebe.broker.backpressure but zeebe.broker.flowControl takes precedence.

Related issues

closes #18120

@github-actions github-actions bot added the component/zeebe Related to the Zeebe component/team label May 8, 2024
@oleschoenburg oleschoenburg force-pushed the os/uc-flow-control branch 2 times, most recently from 853c2d9 to 1ee4844 Compare May 8, 2024 14:29
@github-actions github-actions bot added component/operate Related to the Operate component/team component/tasklist Related to the Tasklist component/team labels May 21, 2024
@oleschoenburg oleschoenburg force-pushed the os/uc-flow-control branch 2 times, most recently from e3fb208 to 51ffa1e Compare May 21, 2024 15:58
@oleschoenburg oleschoenburg removed component/operate Related to the Operate component/team component/tasklist Related to the Tasklist component/team labels May 21, 2024
@oleschoenburg oleschoenburg marked this pull request as ready for review May 21, 2024 16:38
Copy link
Contributor

@rodrigo-lourenco-lopes rodrigo-lourenco-lopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes 🚀 🚀 Just take a look at the suggestions before merging if they make sense.

@github-actions github-actions bot added component/operate Related to the Operate component/team component/tasklist Related to the Tasklist component/team labels May 22, 2024
@oleschoenburg oleschoenburg added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 4d797d2 May 22, 2024
40 checks passed
@oleschoenburg oleschoenburg deleted the os/uc-flow-control branch May 22, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/operate Related to the Operate component/team component/tasklist Related to the Tasklist component/team component/zeebe Related to the Zeebe component/team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User command flow control is handled in the log stream
2 participants