ci: build Tasklist and Operate frontends in distribution module #18483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houssain-barouni
added
component/operate
|
Since Tasklist and Operate will be started from |
Zelldon
approved these changes
May 17, 2024
Comment on lines
+176
to
+181
| # -DskipQaBuild=true -P-autoFormat,buildDistFrontend,skipFrontendBuild | ||
| # In order to disable QA/IT and the auto formatting during the release. | ||
| # It is unnecessary to release integration tests, and we don't want to run the auto-formatting unnecessarily. | ||
| # Building Operate and Tasklist frontend packages does not work in concurrent mode: | ||
| # - It is necessary to build the frontend packages in a single place, from dist module, using buildDistFrontend profile | ||
| # - It is necessary to skip frontend build in the respective Operate and Tasklist client modules using skipFrontendBuild profile |
| ./mvnw release:perform -B \ | ||
| -Dgpg.passphrase="${{ steps.secrets.outputs.MAVEN_CENTRAL_GPG_SIGNING_KEY_PASSPHRASE }}" \ | ||
| -DlocalCheckout=${{ inputs.dryRun }} \ | ||
| -DskipQaBuild=true \ | ||
| -P-autoFormat \ | ||
| -Darguments='-P-autoFormat -DskipQaBuild=true -DskipChecks=true -DskipTests=true -Dskip.fe.build=false -Dspotless.apply.skip=false -Dskip.central.release=${SKIP_REPO_DEPLOY} -Dskip.camunda.release=${SKIP_REPO_DEPLOY} -Dzbctl.force -Dzbctl.rootDir=${ZBCTL_ROOT_DIR} -Dgpg.passphrase="${{ steps.secrets.outputs.MAVEN_CENTRAL_GPG_SIGNING_KEY_PASSPHRASE }}"' |
There was a problem hiding this comment.
Can't remember anymore. Did we skipped the build per default now and enabled it here again? Do we maybe need to change here as well? Meaning this one -Dskip.fe.build=false
There was a problem hiding this comment.
-Dskip.fe.build=false forces the fe build at client modules level, now it is not needed as the fe is built at dist level
as I said above, I will simplify this in this pull request as now Tasklist and Operate entrypoints are in dist and not in the webapps anymore, stay tuned :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to fix the issues found when running
release:performwith concurrency, yarn install could not be run at the same time for Operate and Tasklist, thus we had to disable the concurrency for the releasing (which make it taking ~6 minutes longer)In this pull request,
frontend-maven-pluginexecutions are run bydistmodule to ensure that they are not run in parallel, it also allows thatinstall-node-and-yarngoal is excuted only once.A new profile
buildDistFrontendwas created to be used for mvnrelease:performalong withskipFrontendBuildthat skips the same plugin executions in client submodules in Tasklist and OperateThe plugin is kept though in client modules, to allow developers to start the applications using webapp only (without building and running the single JAR)
Dry-run for this branch https://github.com/camunda/zeebe/actions/runs/9075444643
Related issues
closes #