Migrate child process instances #18509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korthout
approved these changes
May 15, 2024
There was a problem hiding this comment.
Thanks @berkaycanbc 🚀 This will enable a lot of new migrations use cases!
👍 Great work analyzing whether call activity properties need updates!
❌ I have a single change request. Please add the requested assertion and feel free to merge after. So, I'll pre-approve it.
...va/io/camunda/zeebe/engine/processing/processinstance/migration/MigrateCallActivityTest.java
Show resolved
Hide resolved
...amunda/zeebe/engine/processing/processinstance/ProcessInstanceMigrationMigrateProcessor.java
Outdated
Show resolved
Hide resolved
Three different test cases are added. First one is testing if the migration of a child process instance can be successfully completed. Second, the test verifies if the flow can continue as expected in both parent and child process instances. Third, we add test if cancellation of a parent process instance still works as expected. It is basically the same test cases as we have for call activity migration but with migrating child process instance this time.
The test was implemented to make sure we reject migrating child process instances. But with this PR, we support migrating them. Therefore, the related test is removed.
The precondition to prevent migrating child process instances is removed. There's no need to do anything to the child process instance specifically. We've verified that the call activity that is referencing the migrated child process instance does not have any properties that needs to be updated on migration. Following fields can be changed during the migration of child process instance: - the process definition key of the child process instance - the bpmn process id of the child process instance - the version of the child process instance - the element id of the active element inside the child process instance Checked following classes to see if anything needs to be updated for the calling call activity: `ProcessInstanceRecord` -> no data kept for child process instance `ElementInstance` -> only called child instance's key is kept but it will not change during the migration `DBElementInstanceState` -> parent and child instances are connected through instance keys that will not change during the migration of child process instance Therefore, there is no need to update call activity neither in log stream nor in the state.
berkaycanbc
force-pushed
the
bcan-15922-migrate-child-process-instances
branch
from
a0aac70
to
fc088b1
Compare
|
/backport |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/8.5
git worktree add -d .worktree/backport-18509-to-stable/8.5 origin/stable/8.5
cd .worktree/backport-18509-to-stable/8.5
git switch --create backport-18509-to-stable/8.5
git cherry-pick -x ac9c59550d9231f78db35a24c28ca146a8970036 7a352801196dc170b25f35bf478eb460fe4a8373 fc088b120deb1e23c36b961d9d46719ceaf22d3c |
|
/backport |
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 22, 2024
# Description Backport of #18509 to `stable/8.5`. relates to #18328 #15922 original author: @berkaycanbc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've verified that the call activity that is referencing the migrated child
process instance does not have any properties that needs to be updated on migration.
Following fields can be changed during the migration of child process instance:
Checked following classes to see if anything needs to be updated for the calling
call activity:
ProcessInstanceRecord-> no data kept for child process instanceElementInstance-> only called child instance's key is kept but it will not changeduring the migration
DBElementInstanceState-> parent and child instances are connected through instancekeys that will not change during the migration of child process instance
Therefore, there is no need to update call activity neither in log stream nor in the
state.
Related issues #18328
closes #15922