Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ANALYZE results in postgres sentry reports #432

Closed
bloodearnest opened this issue Mar 22, 2019 · 1 comment
Closed

Include ANALYZE results in postgres sentry reports #432

bloodearnest opened this issue Mar 22, 2019 · 1 comment

Comments

@bloodearnest
Copy link
Contributor

When collecting sql SQLqueries to include in sentry reports, it would be need to include the results of ANALYZE on those queries.

This should be ok, performance wise, as usually the sentry report is generated at sent after the response has been sent to the user, but maybe there should be a limit on the number of ANALYZES, and we do them against slowest queries first.

We should only collect these in case of error, using raven's callback api, as while not expensive

@bloodearnest
Copy link
Contributor Author

This landed in #499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant