refactor wsgi request logging, for more context #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bloodearnest
commented
Dec 4, 2019
| self.old_statsd = talisker.statsd.get_client.raw_update( | ||
| self.statsd_client) | ||
| talisker.logs.add_talisker_handler(logging.NOTSET, self.handler) | ||
| self.sentry_context.start() | ||
| Context.new() | ||
|
|
There was a problem hiding this comment.
FTR - this is a driveby UX improvement - the previous lines generates logs, moving the new context to here means those logs are not captured as part of the context.
bloodearnest
commented
Dec 4, 2019
| WSGIMetric.errors.inc(**labels) | ||
|
|
||
| return extra | ||
|
|
||
|
|
There was a problem hiding this comment.
These two methods are virtually unchanged from their module function versions.
bloodearnest
commented
Dec 4, 2019
| extra={'request_id': rid} | ||
| ) | ||
| else: | ||
| REQUESTS[rid] = request | ||
|
|
There was a problem hiding this comment.
We now track the entire request object, rather than just the environ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames WSGIResponse to TaliskerWSGIRequest, as it's not really just a response. Moves the logic of request logging/metrics into the class, so more context is available. Later changes will use this extra context to enhance sentry reports.