Sentry logging breadcrumb fixes #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonysimpson
approved these changes
Dec 11, 2019
Ensure that there is an active sentry context by activating it before each request. Previously, there was no active context for the very first request a worker served. Also improves logging breadcrumbs: - remove duplicated information - condense file/lineno/funcName into one item - stringify keys so breadcrumb displays properly Cleans up the depreacted use of LogRecord._structured
bloodearnest
force-pushed
the
better-sentry-reports
branch
from
5736297
to
70097f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that there is an active sentry context by activating it before
each request. Previously, there was no active context for the very first
request a worker served.
Also improves logging breadcrumbs:
Cleans up the depreacted use of LogRecord._structured