Better gunicorn timeout handling. #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By raising our own exception in Gunicorn's worker_abort handler, we can catch and handle it just like any other error. This means we get an error response, logging, and sentry report for the timeout, which is a massive improvement. Also includes a few of drive-by tweaks - disable parallel pytest runs in tox, as it generally confuses things, tweak the error message for assert_log help to reduce noise, and slight tweaks to the title of the default error pages.
bloodearnest
force-pushed
the
gunicorn-timeouts
branch
from
bdac91a
to
5ca91c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By raising our own exception in Gunicorn's worker_abort handler, we can
catch and handle it just like any other error. This means we get an
error response, logging, and sentry report for the timeout, which is
a massive improvement.
Also includes a few of drive-by tweaks - disable parallel pytest runs in tox, as it generally confuses things, tweak the error message for assert_log help to reduce noise, and slight tweaks to the title of the default error pages.