Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge vanillaframework.io site and the docs to into one project #2871

Merged
merged 24 commits into from Mar 5, 2020
Merged

Merge vanillaframework.io site and the docs to into one project #2871

merged 24 commits into from Mar 5, 2020

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Mar 3, 2020 •
edited

QA:

  • check if docs.staging.vanillaframework.io works

TODO:

  • select correct page in nav
  • fix docs. links to /docs
  • clean up commented meta data in .html files from site (descriptions, copydoc, etc)
  • copydoc
  • remove / update links to docs.vanillaframework

LATER:

  • use templates instead of the site for consistency with other projects
  • try to move common parts to includes (<head>, navigation, footer...)
  • review how much of custom docs/site css is needed
  • review head tags of docs/site (GA, lazy loading, usabilla, etc)
  • release drafter template
  • PWA: app-iconsmanifest.json, sw.js (service worker / offline), sitemap

@webteam-app
Copy link

Starting demo at: https://vanilla-framework-canonical-web-and-design-pr-2871.run.demo.haus/

@bartaz bartaz force-pushed the one-site branch 3 times, most recently from 755c36a to 8ae172b Compare March 4, 2020 14:40
@bartaz bartaz marked this pull request as ready for review March 5, 2020 08:49
@bartaz bartaz added the Documentation 📝 Documentation changes or updates label Mar 5, 2020
@bartaz bartaz merged commit dba7dfc into master Mar 5, 2020
@bartaz bartaz changed the title DEMO: One site to rule them all Merge vanillaframework.io site and the docs to into one project Mar 5, 2020
@bartaz bartaz deleted the one-site branch March 5, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkfran jkfran jkfran approved these changes

Assignees
No one assigned
Labels
Documentation 📝 Documentation changes or updates Maintenance 🔨 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartaz @webteam-app @jkfran