Remove bottom margin from label component #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartaz
changed the title
bartaz
force-pushed
the
remove-label-margin
branch
from
c0dd2fc
to
9df1879
Compare
lyubomir-popov
approved these changes
Mar 16, 2020
lyubomir-popov
added
Review: Code +1
Review: Design +1
and removed
Review: Code needed
Review: Design needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
As label component is used mostly inline alongside text or in paragraphs it shouldn't have margin of it's own (as it usually needs to be removed with u-no-margin).
QA
./runhttp://0.0.0.0:8101/ or demo