Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align side navigation group border with text #2935

Merged
merged 1 commit into from Mar 18, 2020
Merged

Align side navigation group border with text #2935

merged 1 commit into from Mar 18, 2020

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Mar 18, 2020 •
edited

In side navigation with icons on left align group border with text rather than icon

QA

Before

Screenshot 2020-03-18 at 06 46 15

After

Screenshot 2020-03-18 at 06 44 22

@bartaz bartaz added the Feature 🎁 New feature or request label Mar 18, 2020
@webteam-app
Copy link

Starting demo at: https://vanilla-framework-canonical-web-and-design-pr-2935.run.demo.haus/

lyubomir-popov
lyubomir-popov approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@lyubomir-popov lyubomir-popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartaz bartaz merged commit ca2a9ec into canonical:master Mar 18, 2020
@bartaz bartaz deleted the side-navigation-nester-border branch March 18, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyubomir-popov lyubomir-popov lyubomir-popov approved these changes

@spencerbygraves spencerbygraves Awaiting requested review from spencerbygraves

Assignees

@lyubomir-popov lyubomir-popov

@spencerbygraves spencerbygraves

Labels
Feature 🎁 New feature or request Review: Code +1 Review: Design +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bartaz @webteam-app @lyubomir-popov @spencerbygraves