Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent pretty-quick from commiting changes in husky hook #2941

Merged
merged 1 commit into from Mar 20, 2020
Merged

Prevent pretty-quick from commiting changes in husky hook #2941

merged 1 commit into from Mar 20, 2020

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Mar 19, 2020 •
edited

Done

Makes sure pretty-quick only checks commited files, not autofixes them.
Removes outdated package.json comments.

QA

  • Pull code, (yarn install if you haven't set up vanilla before)
  • Make some changes that would fail prettier (remove ; in any SCSS file)
  • Try to commit this change
  • Precommit hook should fail and prevent the commit

Screenshot 2020-03-19 at 15 13 58

@webteam-app
Copy link

Starting demo at: https://vanilla-framework-canonical-web-and-design-pr-2941.run.demo.haus/

@sowasred2012 sowasred2012 self-assigned this Mar 20, 2020
sowasred2012
sowasred2012 approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@sowasred2012 sowasred2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM 👍

@bartaz bartaz merged commit 0d6a235 into canonical:master Mar 20, 2020
@bartaz bartaz deleted the husky-check branch March 20, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sowasred2012 sowasred2012 sowasred2012 approved these changes

Assignees

@sowasred2012 sowasred2012

Labels
Maintenance 🔨 Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartaz @webteam-app @sowasred2012